Enforce four clean custom linters in CGO - #51682
Merged
Merged
Conversation
4 tasks
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Enforce readiness for cleaner linters without production violations
Enforce four clean custom linters in CGO
Aug 10, 2026
pelikhan
marked this pull request as ready for review
August 10, 2026 05:02
Contributor
There was a problem hiding this comment.
Pull request overview
Enforces four clean custom Go analyzers in production CI for native and WASM builds.
Changes:
- Enables
globwalkignorederror,appendbytestring,sortslice, anddeferinloop. - Preserves production-only scope with
-test=false.
Show a summary per file
| File | Description |
|---|---|
.github/workflows/cgo.yml |
Adds the four analyzers to native and WASM lint gates. |
Review details
Tip
Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Four registered, type-resolved custom analyzers were not included in the production CI gate despite having no current production findings. This adds regression coverage for ignored filesystem errors, redundant byte-string appends, legacy sort helpers, and loop-scoped defers.
CGO production lint gate
globwalkignorederrorappendbytestringsortslicedeferinloopWASM parity
LINTER_FLAGS="... -globwalkignorederror -appendbytestring -sortslice -deferinloop -test=false"